Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages #96

Closed
5 of 7 tasks
tangjeff0 opened this issue May 27, 2020 · 9 comments
Closed
5 of 7 tasks

Pages #96

tangjeff0 opened this issue May 27, 2020 · 9 comments
Assignees

Comments

@tangjeff0
Copy link
Collaborator

tangjeff0 commented May 27, 2020

Tasks

@nthd3gr33
Copy link
Contributor

Please comment @itsrainingmani @alaq so I can assign our team to this issue.

@itsrainingmani
Copy link
Contributor

Let's go @nthd3gr33 !

@nthd3gr33 nthd3gr33 self-assigned this Jul 20, 2020
@alaq
Copy link
Contributor

alaq commented Jul 20, 2020

👋

@nthd3gr33
Copy link
Contributor

(Fat fingers, sorry 😅 )

We started looking into the shortcut part of this issue, but we have discovered that quite a bit was already done. So we will likely move on to the deleting pages part of the issue.

We have questions about implementation of this feature, specifically in regards to expected UX for deleting pages:

  1. In Roam, you can check pages in the All Pages list and then you can bulk delete. Do we also want to implement that here? Or are bulk operations out of the scope of this issue?
  2. What happens to empty pages that have no links to them. Do we keep them? Eagerly delete them?
  3. If you delete a page, should all corresponding links to it be deleted? (this is current Roam behavior)

@tangjeff0 tangjeff0 mentioned this issue Jul 21, 2020
3 tasks
@tangjeff0
Copy link
Collaborator Author

The main part remaining for shortcuts is decrementing all the indices after the index that was removed, which is NBD.

  1. Bulk operations are part of All Pages, out of scope.
  2. Can you give me an example?
  3. Yes, and we have all the :block/uids in linked references.

Made #292 for you three. I also think you can assign yourselves to the issue now. I had to add the athens repo to the devs team.

@alaq
Copy link
Contributor

alaq commented Jul 21, 2020

  1. Can you give me an example?

We're thinking of pages that were created by a link, but the link was later removed. Here is what is happening in Roam:

  1. Create new block with link to [[new page]]
  2. new page is visible in All Pages
  3. remove link to new page in new block
  4. new page is no longer visible in All Pages (it has been deleted)

@tangjeff0
Copy link
Collaborator Author

tangjeff0 commented Jul 21, 2020

Yeah, we should delete orphan pages, if they were created as a result of block writing. We should probably keep orphan pages if they are created through "Create New Page" functionality. But I'm not entirely sure how to distinguish these two cases.

@hmaurer
Copy link

hmaurer commented Sep 2, 2020

I am looking through issues for a good first contribution. This seems interesting, have there been developments since your last comment @tangjeff0 ?

@tangjeff0
Copy link
Collaborator Author

Hi @hmaurer, Pages are mainly done. There are better first issues on https://github.com/athensresearch/athens/projects/4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants