-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages #96
Comments
Please comment @itsrainingmani @alaq so I can assign our team to this issue. |
Let's go @nthd3gr33 ! |
👋 |
(Fat fingers, sorry 😅 ) We started looking into the shortcut part of this issue, but we have discovered that quite a bit was already done. So we will likely move on to the deleting pages part of the issue. We have questions about implementation of this feature, specifically in regards to expected UX for deleting pages:
|
The main part remaining for shortcuts is decrementing all the indices after the index that was removed, which is NBD.
Made #292 for you three. I also think you can assign yourselves to the issue now. I had to add the athens repo to the devs team. |
We're thinking of pages that were created by a link, but the link was later removed. Here is what is happening in Roam:
|
Yeah, we should delete orphan pages, if they were created as a result of block writing. We should probably keep orphan pages if they are created through "Create New Page" functionality. But I'm not entirely sure how to distinguish these two cases. |
I am looking through issues for a good first contribution. This seems interesting, have there been developments since your last comment @tangjeff0 ? |
Hi @hmaurer, Pages are mainly done. There are better first issues on https://github.com/athensresearch/athens/projects/4. |
Tasks
The text was updated successfully, but these errors were encountered: