feat(athena): scroll search results with arrow keys #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsrainingmani
changed the title
tangjeff0
requested changes
Jul 20, 2020
WIP implementation of scrolling on arrow key using scrollIntoView. This implementation also prevents navigating beyond the first or last element (no cycling through the list) Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
…re's only one logical branch being used Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
…ult. chore: refactor code to use e.target and element.closest instead of css selectors Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
itsrainingmani
force-pushed
the
athena-arrow-scroll
branch
from
6fe8569
to
35b4e47
Compare
* Move is-beyond-rect? into utils.cljc * Add comments to the key up code * Refactor the result-el selector
itsrainingmani
force-pushed
the
athena-arrow-scroll
branch
from
35b4e47
to
c2830ca
Compare
|
Hi @tangjeff0 . I've made the required changes. The only thing I'm a little unsure of is how much commenting the event handler needed. So let me know if it's too much |
tangjeff0
approved these changes
Jul 20, 2020
Comment on lines
+212
to
+213
| ;; Get the result list container which is the last element child | ||
| ;; of the whole athena component |
There was a problem hiding this comment.
This makes a lot more sense to me now. I'm pretty sure I wrote [:div.athena], but that should probably be an HTML id. .athena also doesn't do anything functionally, so maybe not that useful.
This could also be simplified if we just gave an HTML id/class to the results list directly, but not important.
There was a problem hiding this comment.
@tangjeff0 Agreed on the HTML id thing. I think using id's all over the place might be overkill but could be very useful in simplifying the logic in cases where we need to access very commonly used elements.
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
* fix athena - scroll on arrow key navigation WIP implementation of scrolling on arrow key using scrollIntoView. This implementation also prevents navigating beyond the first or last element (no cycling through the list) Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * fix athena: remove redundant do stmts and change if to when since there's only one logical branch being used Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * feature: wrap around list when you reach the first or last search result. chore: refactor code to use e.target and element.closest instead of css selectors Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * Move bounds checking code into its own function Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * Refactor the control flow for scrollIntoView to be simpler Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * feat(athena): Remove unnecessary comments * Move is-beyond-rect? into utils.cljc * Add comments to the key up code * Refactor the result-el selector Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> Co-authored-by: jeff <tangj1122@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #271 and checks off part of #126
Athena can now scroll through the search results with arrow keys. The implementation also cycles through the search result list.