Updating README remove note about polyfill for IE 11 #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
approved these changes
Nov 19, 2018
|
🤘 |
|
I'm using the |
|
Really? I cannot find the usage. This might be changed in the next alpha
…On Tue, Jun 18, 2019 at 10:08 AM Peter Mikitsh ***@***.***> wrote:
I'm using the v12.0.0-alpha.1 release and I've found that the
Array.prototype.fill polyfill is needed for IE 11.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#933?email_source=notifications&email_token=AAQU33MUBWNR372FCB5H3ZLP3ARRRA5CNFSM4GFCTQO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4ZFPY#issuecomment-502895295>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQU33KHRDVBYNIKM33Y6U3P3ARRRANCNFSM4GFCTQOQ>
.
|
|
If it's any help, here's a screenshot of where the exception is thrown.
|
|
Looks like it's in the
|
|
Perfect! I will remove this
…On Tue, Jun 18, 2019 at 11:55 AM Peter Mikitsh ***@***.***> wrote:
Found it here:
https://github.com/atlassian/react-beautiful-dnd/blob/virtual/src/view/use-focus-marshal/use-focus-marshal.js#L33
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#933?email_source=notifications&email_token=AAQU33J6KC5QEAXGBKNPUHTP3A6BBA5CNFSM4GFCTQO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4526Q#issuecomment-502914426>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQU33KLWJPDB7AYWMT5HRDP3A6BBANCNFSM4GFCTQOQ>
.
|
|
This has shipped in `12.0.0-alpha.3`
On Tue, Jun 18, 2019 at 1:58 PM Alexander Reardon <areardon@atlassian.com>
wrote:
… Perfect! I will remove this
On Tue, Jun 18, 2019 at 11:55 AM Peter Mikitsh ***@***.***>
wrote:
> Found it here:
> https://github.com/atlassian/react-beautiful-dnd/blob/virtual/src/view/use-focus-marshal/use-focus-marshal.js#L33
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#933?email_source=notifications&email_token=AAQU33J6KC5QEAXGBKNPUHTP3A6BBA5CNFSM4GFCTQO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4526Q#issuecomment-502914426>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAQU33KLWJPDB7AYWMT5HRDP3A6BBANCNFSM4GFCTQOQ>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of release v10 the
Array.prototype.findpolyfill for IE 11 is no longer neededsee: #724 (comment)