Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Implement naming conventions in template theme #883

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Conversation

chbk
Copy link
Contributor

@chbk chbk commented Mar 17, 2020

Description of the Change

This is a rewrite of the template theme to implement naming conventions for syntax scopes.

Benefits

The naming conventions really shine through in this PR. Simply filling out the template is enough to ensure coherent highlighting across languages. This is what the original template tried to achieve, but without clear naming conventions, the resulting syntax highlighting was too inconsistent. The most notable improvements are on punctuation and types.

Possible Drawbacks

Some additional scopes absent from old grammars, but besides that no obvious incompatibilities, most scopes stay the same. PRs to make grammars fully compatible are linked below.

Applicable Issues

Related Pull Requests

@chbk chbk marked this pull request as draft July 30, 2020 16:09
@chbk chbk force-pushed the scopes branch 2 times, most recently from 047f477 to c718233 Compare August 24, 2020 16:24
@chbk chbk marked this pull request as ready for review February 1, 2021 14:33
sadick254 pushed a commit to atom/atom that referenced this pull request Feb 19, 2021
Update of the default syntax themes to implement [naming conventions](atom/flight-manual.atom.io#564) for syntax scopes.

Adds the [template](atom/apm#883) to each theme with custom colors, to accommodate the naming conventions. There should be no compatibility break with existing grammars.

As naming conventions are implemented in more language grammars, their old specific stylesheets can be retired.
@sadick254 sadick254 merged commit 0f0b679 into atom:master Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants