Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update completions json #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeeDeeG
Copy link

@DeeDeeG DeeDeeG commented Feb 20, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Update completions.json.

I did so by running (effectively): npm install -g coffeescript && npx coffee update.coffee.

This adds the following completions:

  • text-justify
  • justify-self
  • justify-items

Alternate Designs

I considered trying to source some descriptions from somewhere for these three new properties, and manually entering them into completions.json. I have not done so yet. but it could probably be done pretty easily.

Benefits

Provides completions for more CSS properties.

Possible Drawbacks

Not a downside to this change really, but a note: I noticed that the upstream source of data removed all the descriptions. I though this was a shame, so I preserved the existing descriptions. I had to add these new changes carefully.

I chose to do git add -p completions.json and skipped all of the changes other than adding these new properties to the list. I had to manually edit some diff hunks in order to make them apply without removing existing descriptions.

There may be a less tedious or repetitive way to do this, but it worked for me.

So a word of advice: Be careful when updating completions.json in the future. As mentioned above, I think it would be a shame to delete all the descriptions.

Applicable Issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant