This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Update
completions.json
.I did so by running (effectively):
npm install -g coffeescript && npx coffee update.coffee
.This adds the following completions:
text-justify
justify-self
justify-items
Alternate Designs
I considered trying to source some descriptions from somewhere for these three new properties, and manually entering them into
completions.json
. I have not done so yet. but it could probably be done pretty easily.Benefits
Provides completions for more CSS properties.
Possible Drawbacks
Not a downside to this change really, but a note: I noticed that the upstream source of data removed all the descriptions. I though this was a shame, so I preserved the existing descriptions. I had to add these new changes carefully.
I chose to do
git add -p completions.json
and skipped all of the changes other than adding these new properties to the list. I had to manually edit some diff hunks in order to make them apply without removing existing descriptions.There may be a less tedious or repetitive way to do this, but it worked for me.
So a word of advice: Be careful when updating
completions.json
in the future. As mentioned above, I think it would be a shame to delete all the descriptions.Applicable Issues