This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Use local paths whenever possible and place favicon to root #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs updated to use HTTPS protocol where appropriate to improve security and privacy.
|
Looks good to me, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves upon #421 and does two noteworthy things:
Removes
https://flight-manual.atom.iofrom links within articles. This makes such links protocol agnostic and when viewing a locally compiled version, you'll be not redirected out of your local copy.Moves
favicon.icoto the root of domain.The gulp task for copying the favicon already copied the icon file to the root of output, however the automatic prune functionality from nanoc deleted the file quickly after. Adding the file to nanoc exclusion list solves that.
In templates it is still beneficial to reference
/favicon.icoas the icon of choice in case the browser does not look for it automatically. I moved the relevant<link>tag closer to others, which simplifies things a bit. The path to favicon is now also protocol agnostic.