Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Replace screenshots #90

Merged
merged 16 commits into from
Jul 12, 2015
Merged

Replace screenshots #90

merged 16 commits into from
Jul 12, 2015

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 2, 2015

This PR replaces all screenshots with an updated 1.0 look and feel.

@thomasjo
Copy link
Contributor

thomasjo commented Jul 2, 2015

Looks like you're using some sort of custom Finder shell (ref. book/01-introduction/images/open-file.png), perhaps it would be wise to use stock Finder to avoid confusion about missing checkbox and New Folder button? HERPADERP.

@mnquintana
Copy link
Contributor

@thomasjo I think that is stock Finder - it's just the open dialog, rather than a regular Finder window.

@thomasjo
Copy link
Contributor

thomasjo commented Jul 2, 2015

I got a little confused when I wrote that comment. The New Folder button is certainly stock, but the... wait. There checkbox shows up if one hasn't checked the "Show all file extensions" option. So this is truly stock behavior indeed! Thanks for the clarification @mnquintana, and sorry to @simurai about the confusion 🙇

Use an active state for the open window.
@simurai
Copy link
Contributor Author

simurai commented Jul 2, 2015

Maybe it also looked a bit odd because the window was not active.. I replaced it with an active one (blue Open button). Also the colored tags are shown:

open-file

@simurai
Copy link
Contributor Author

simurai commented Jul 10, 2015

Ok, I think this is ready.

In general it's a bit more "zoomed in", so it should be easier to see details and read text.

lee-dohm added a commit that referenced this pull request Jul 12, 2015
@lee-dohm lee-dohm merged commit a244e1a into master Jul 12, 2015
@lee-dohm
Copy link
Contributor

Thanks @simurai 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants