Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Use N-API prebuilds #106

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Use N-API prebuilds #106

merged 4 commits into from
Apr 27, 2021

Conversation

sergiou87
Copy link
Collaborator

@sergiou87 sergiou87 commented Apr 20, 2021

This PR sits on top of #105 and was inspired by atom/node-keytar#331

I still have to test it properly, I'll update this when I have more to share 😄

Tested on https://github.com/desktop/desktop and works perfectly!

@sergiou87
Copy link
Collaborator Author

For those interested, I uploaded a test build of GitHub Desktop that includes fs-admin with the changes from this PR (which also include #105), and it works fine!

Download: https://s3.amazonaws.com/github-desktop/releases/2.7.3-test4-0e14ef24/GitHubDesktop-arm64.zip

@sergiou87 sergiou87 changed the title [WIP] Use N-API prebuilds Use N-API prebuilds Apr 27, 2021
@sergiou87 sergiou87 merged commit 09a0618 into atom:master Apr 27, 2021
@sergiou87 sergiou87 deleted the use-napi-prebuilds branch April 27, 2021 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants