Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

More lenient queries #10

Closed
michaelhelmick opened this issue Feb 27, 2014 · 19 comments
Closed

More lenient queries #10

michaelhelmick opened this issue Feb 27, 2014 · 19 comments

Comments

@michaelhelmick
Copy link

I submitted feedback in Atom.app, but I ultimately thought it would be a good idea to post it here.

searching

As you can see my query lass soci and lass fil soc both returned social.py in the results which is nested in lassie/filters/social.py

In atom, if I wanted to use Fuzzy Finder to find social.py I would have to type exactly lassie/filters to get a list of the files in filters or social.py -- But in, say, a Django project, where you have multiple urls.py, it might not be as easy to search just urls.py; you could get a ton of results.

Say my app/folder name was campaigns, I'd like to be able to search camp urls and that return me project/campaigns/urls.py in the results.

This functionality is similar to how Sublime Text returns results.

@amccloud
Copy link

It would also be nice if cmpgn ur would return project/campaigns/urls.py. Maybe we can use https://github.com/rmm5t/liquidmetal?

@kevinsawicki
Copy link
Contributor

Yeah, we currently use https://github.com/atom/fuzzaldrin but are open to whatever works best.

@amccloud
Copy link

I don't see fuzzaldrin mentioned anywhere in this project. Is that logic
client or server side.

On Wednesday, February 26, 2014, Kevin Sawicki notifications@github.com
wrote:

Yeah, we currently use https://github.com/atom/fuzzaldrin but are open to
whatever works best.

Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-36196215
.

@kevinsawicki
Copy link
Contributor

Sorry, should have mentioned more, it is managed by the SelectListView superclass here: https://github.com/atom/fuzzy-finder/blob/master/lib/fuzzy-finder-view.coffee#L6

SelectListView is in the public API but the source for it isn't available. All the filter boxes, cmd-t, cmd-shift-p, cmd-r, all use the same filter code, fuzzaldrin.

http://atom.io/docs/api/v0.60.0/api/classes/SelectListView.html

@amccloud
Copy link

@michaelhelmick given matching candidates /bar/foo and /foo/bar with the input br f it's clear that /bar/foo should score higher. When given matching candidates /bar/foo and /foo/bar foo, with the same input, which one should score higher? I believe /foo/bar foo should.

I've started specs for this in fuzzaldrin atom/fuzzaldrin#3

@paulozoom
Copy link

Besides paths, something else that I think people do quite frequently is typing the extension as part of the search e.g. forms css, login html. This is especially useful when strong naming conventions are enforced, such as in Rails projects.

Right now, it seems as fuzzy-finder ignores extensions completely. It'd be good to have them included.

@adammeghji
Copy link

@amccloud that PR works well -- in my case, I also want spaces to match underscores in filenames, and your modification seems to accommodate that use case as well. Thanks!

@michaelhelmick
Copy link
Author

@paulozoom That's a good idea, I do that often too -- type the file extension at the end to try and get clearer results.

@amccloud I think /foo/bar foo could score higher, too.

@timrogers
Copy link

I'm used to the fuzzy finding from Sublime and TextMate - e.g. arc.rb should lead to something like /app/models/referral_code.rb, which the current fuzzy finder in Atom doesn't do.

@probablycorey
Copy link

Just a heads up, if you don't use spaces (e.g. formscss instead of forms css) Atom's fuzzy finder should match. But it looks like uses spaces is an expected behavior we should also allow.

@amccloud
Copy link

@probablycorey My PR strips spaces from the input so that form css works.

@olivierlacan
Copy link

@probablycorey Yes. I've seen several ST users search without spaces but for clarity I've grown accustomed to separating clauses when I'm looking for a nested file:

module classname is how I generally look for lib/module/classname.rb

@probablycorey
Copy link

This is now fixed in Atom 0.61.0.

@amccloud
Copy link

@probablycorey I remember seeing an update button inside of Atom but now I can't seem to find it 😞

@hkdobrev
Copy link

Atom menu -> Check for updates.

Unfortunately I am on 0.60.0 and it can't detect the update. Any solutions?

@probablycorey
Copy link

It can take ~30 minutes for the update to propagate. It's an annoying quirk we plan on fixing.

@amccloud
Copy link

@probablycorey Is there a changelog for Atom?
@hkdobrev Oddly enough that doesn't show up every time I click Atom in the menubar.

@michaelhelmick
Copy link
Author

Thanks for the fix guys! 🍰

@probablycorey
Copy link

@amccloud Those are all good questions. Could should ask them over at discuss.atom.io so other people can search for them better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants