This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add support for properties and relax support.function regex #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨⚠️ Do not merge yet! Specs on atom/atom also need to be updated! ⚠️ 🚨
This PR replaces #210, brings back #158, and combines it with #146.
support.function.dom.js
has been kept and is prioritized over the now-generalizedsupport.function.js
regex.entity.name.property.js
now catches anything that doesn't fall intosupport.constant{.dom}.js
andsupport.class.js
Before:
After:
/cc @bucaran since I know you had some concerns about this
/cc @nevir because this only adds
.property
for things not already marked as.class
and.constant
/cc @Victorystick, @AMalininHere, @pchaigno
Refs #137
Fixes #37
Closes #146