This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
fix: add numeric separators #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@darangi @sadick254 can this get reviewed? |
UziTech
force-pushed
the
numeric-separators
branch
7 times, most recently
from
2ccf102 to
7a1e4f0
Compare
UziTech
force-pushed
the
numeric-separators
branch
from
7a1e4f0 to
4214478
Compare
|
Woot 🎉 merged in under a year. I'll take that as a win. lol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
tokenize numeric separators
Benefits
numeric separators will be tokenized
Possible Drawbacks
none
Applicable Issues
fixes #669