Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Clarify "Strings File" is for Objective-C #21

Closed
wants to merge 1 commit into from
Closed

Clarify "Strings File" is for Objective-C #21

wants to merge 1 commit into from

Conversation

wesinator
Copy link

@wesinator wesinator commented Feb 14, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Clarify that strings file grammar name is for Objective-C

For example, this is what you currently see with the grammar selector:

grammar-selector

This would now say Strings File (Objective-C).

Alternate Designs

Benefits

More clear that the Strings File grammar is for Objective-C.

Possible Drawbacks

N/A

Applicable Issues

N/A

@rsese
Copy link

rsese commented Feb 15, 2019

Thanks @wesinator - just to clarify, I assume this is in particular to improve clarity when displayed in the grammar selector?

@wesinator
Copy link
Author

Yes. also atom/autocomplete-plus#743

@rsese
Copy link

rsese commented Feb 21, 2019

Thanks for clarifying 👍 I tweaked the issue body a bit to add a tiny bit more detail for the benefit of whoever reviews the pull request (feel free to edit anything if you want).

Someone from the team will take a look as soon as they can.

@wesinator wesinator changed the title Clarify Strings File name Clarify "Strings File" is for Objective-C Mar 2, 2019
@jasonrudolph jasonrudolph self-assigned this May 22, 2019
@jasonrudolph
Copy link
Contributor

Thanks, @wesinator! 🙇

@jasonrudolph
Copy link
Contributor

Merged in 461beb2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants