-
Notifications
You must be signed in to change notification settings - Fork 34
Should I publish my userId? #18
Comments
I think it is okay to publish it, it is the sha-1 of your mac address so it won't reveal anything sensitive. Atom should probably store it somewhere else though as this kind of issue illuminates that pretty clearly since it makes dotfiles not as shareable as they should be. |
I find it suspicious that the id is missing from @kevinsawicki 's dotfiles: https://github.com/kevinsawicki/dotfiles/blob/master/.atom/config.cson Would be nice if atom stored this somewhere else, it's a hassle to purge it from my config every time I want to commit my changes. |
@Robru Why is it suspicious? If you disable the |
Ah, sorry, I've got my packages confused. |
I just started using Atom ten minute ago, and found this issue immediately because the first thing I want to do when using a new program is version control its config files. Disabling |
Otherwise we can't exclude `packages/*`.... See thoughtbot/rcm#11 Seems to be ok to share userId: atom/metrics#18
Thanks guys I remove metrics and exception-reporting then removed the userid. now I got that config in my dotfiles :D cheers. |
I agree that the user ID should be stored somewhere else, if its the SHA1 of the mac address its intended to be unique per-machine, which kinda defeats the point of sharing your dotfiles with other users and your own other computers |
The 'userID' is a randomly generated uuid created when the metrics package first activated. It has not been derived from the mac address for a couple of years. |
I noticed
metrics.userId
is stored in my config.cson. I'd like to commit my config.cson to my dotfiles. Should I scrub myuserId
out first?Related to execption-reporting#7
The text was updated successfully, but these errors were encountered: