Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Should I publish my userId? #18

Closed
hurrymaplelad opened this issue Mar 3, 2014 · 8 comments
Closed

Should I publish my userId? #18

hurrymaplelad opened this issue Mar 3, 2014 · 8 comments

Comments

@hurrymaplelad
Copy link

I noticed metrics.userId is stored in my config.cson. I'd like to commit my config.cson to my dotfiles. Should I scrub my userId out first?

Related to execption-reporting#7

@kevinsawicki
Copy link
Contributor

I think it is okay to publish it, it is the sha-1 of your mac address so it won't reveal anything sensitive.

Atom should probably store it somewhere else though as this kind of issue illuminates that pretty clearly since it makes dotfiles not as shareable as they should be.

@ghost
Copy link

ghost commented Mar 9, 2015

I find it suspicious that the id is missing from @kevinsawicki 's dotfiles:

https://github.com/kevinsawicki/dotfiles/blob/master/.atom/config.cson

Would be nice if atom stored this somewhere else, it's a hassle to purge it from my config every time I want to commit my changes.

@thomasjo
Copy link
Contributor

thomasjo commented Mar 9, 2015

@Robru Why is it suspicious? If you disable the metrics package and remove the id, it will stay gone.

@ghost
Copy link

ghost commented Mar 9, 2015

Ah, sorry, I've got my packages confused. exception-reporting and atom-beautify both also put big hash ids in there. I'll be uninstalling those right quick then...

@chris-martin
Copy link

I just started using Atom ten minute ago, and found this issue immediately because the first thing I want to do when using a new program is version control its config files. Disabling exception-reporting is an irksome fix to have to make after reading a homepage so proudly touting "right out of the box" functionality. Is there an issue to move this data out of the config file?

LoicMahieu added a commit to LoicMahieu/dotfiles that referenced this issue Dec 15, 2015
Otherwise we can't exclude `packages/*`.... See thoughtbot/rcm#11
Seems to be ok to share userId: atom/metrics#18
@2E0PGS
Copy link

2E0PGS commented Apr 12, 2016

Thanks guys I remove metrics and exception-reporting then removed the userid. now I got that config in my dotfiles :D cheers.

@drewcassidy
Copy link

I agree that the user ID should be stored somewhere else, if its the SHA1 of the mac address its intended to be unique per-machine, which kinda defeats the point of sharing your dotfiles with other users and your own other computers

@damieng
Copy link
Contributor

damieng commented Dec 4, 2017

The 'userID' is a randomly generated uuid created when the metrics package first activated. It has not been derived from the mac address for a couple of years.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants