Feature/spring cleaning #61
Conversation
…nt navigation bar and status bar. Also bumped robolectric version
build.gradle
Outdated
| @@ -60,6 +60,11 @@ allprojects { | |||
| throw new GradleException("Wildcard dependency forbidden: ${requested.group}:${requested.name}:${requested.version}") | |||
| } | |||
| } | |||
| //Fix for showing 100+ errors from javac when using Android Databinding | |||
There was a problem hiding this comment.
I haven't noticed the errors referenced in that issue. However, it might be worth moving the comment on lines 52 and 53 to above line 57 for clarity.
There was a problem hiding this comment.
I haven't experienced the issue either, just noticed it while browsing on Dagger's github readme.
There was a problem hiding this comment.
Ok, got those two comments moved to lines 55 & 56 👍
| @@ -42,11 +42,6 @@ case "`uname`" in | |||
| ;; | |||
| esac | |||
|
|
|||
| # For Cygwin, ensure paths are in UNIX format before anything is touched. | |||
There was a problem hiding this comment.
Out of curiosity, what prompted the changes to gradle wrapper?
There was a problem hiding this comment.
I think I opened a completely fresh (File > New > New Project) Android Studio project and copied the new gradlew from that new project and pasted it in our starter project's gradlew
There was a problem hiding this comment.
But to answer your question specifically, not sure why things changed. I believe cywin is a windows platform thing.... FWIW
app/src/main/res/values/styles.xml
Outdated
| @@ -2,10 +2,8 @@ | |||
| <resources> | |||
|
|
|||
| <!-- Base application theme. --> | |||
| <style name="AppTheme" parent="Theme.AppCompat.Light.DarkActionBar"> | |||
| <style name="AppTheme" parent="Theme.AppCompat.NoActionBar"> | |||
There was a problem hiding this comment.
The dark theme looks good but curious why the change from the current theme?
There was a problem hiding this comment.
I like dark themes. That was literally the extent of my thinking :P
We can put the purple theme back in before accepting the PR if you want
or if you're ok with the dark theme, that's cool too. Whatever
There was a problem hiding this comment.
If we wanna use the dark theme: no changes to the PR required
If we wanna use the purple theme: I gotta undo some theme changes
If we wanna use both: That's cool too
…id-starter-project into feature/spring-cleaning
|
Here are my thoughts:
For 3 and 4 I'm thinking we leave leave them unchanged under the premise of fixing something only if it's an issue. Pre-emptively fixing something might be solving a problem that doesn't exist and more code = more complexity. Thanks for keeping things current! |
|
RE @atoennis |
|
@stuartsoft After doing some quick research, please update the license year to Feel free to merge after that. Thanks! |
Minor updates to python script
Updated icon assets
Dark theme
Fix for dagger errors when using databinding (google/dagger#306)
Updated copyright and license