This repository has been archived by the owner on Mar 19, 2019. It is now read-only.
Fix TS relative imports by forcing all Rugs var to be exported #156 #160
+203
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddgenome
reviewed
Jan 11, 2017
| val m = p.matcher(str) | ||
| if(m.find()){ | ||
| val varName = m.group(1) | ||
| sb.append("\nexports.").append(varName).append(" = ").append(varName).append(";\n") |
There was a problem hiding this comment.
Couldn't this be sb.append(s"\nexports.$varName = $varName;\n")?
There was a problem hiding this comment.
It could - is that better?
|
|
||
| import com.atomist.source.{ArtifactSource, FileArtifact} | ||
| import com.atomist.project.archive.{AtomistConfig, DefaultAtomistConfig} | ||
| import com.atomist.source.{ArtifactSource} |
There was a problem hiding this comment.
Curly braces superfluous.
|
I'll verify this with the latest CLI and merge it I don't see any issues. Thanks @kipz. |
|
I just ran the latest local build inside the CLI against the handlers project: |
|
It's less code, which seems better to me.
On Wed, Jan 11, 2017, 2:17 PM James Carnegie ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/scala/com/atomist/rug/runtime/js/JavaScriptContext.scala
<#160>:
> }
def getFolder(s: String): Folder = {
val dir = artifacts.findDirectory(s)
if (dir.isEmpty) return null
new ArtifactSourceBasedFolder(artifacts.underPath(s), this, getPath + s + "/")
}
+
+
+ def append(p: Pattern, str: String, sb: StringBuilder): Unit ={
+ val m = p.matcher(str)
+ if(m.find()){
+ val varName = m.group(1)
+ sb.append("\nexports.").append(varName).append(" = ").append(varName).append(";\n")
It could - is that better?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#160>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADiGSQ_uTJkoqh9slfsdkoopkZuoAKRks5rRTjZgaJpZM4Lg81s>
.
--
David Dooling
|
cdupuis
approved these changes
Jan 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Hopefully not a breaking change as there is limited support for automatically exporting legacy ones.
Fixed
when 'export' is used from TS or vars are added to the global exports var
CommonJS module loader cannot find local modules in Rugs #156