This repository has been archived by the owner on Mar 19, 2019. It is now read-only.
Remove node_modules from TypeScript sources path #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move TypeScript sources up several levels to eliminate `node_modules/@atomist` in the source path. GitHub will now properly show diffs to the TypeScript source. Fixes #442 Move TypeScript copy and and generation tasks to the main build, not just on the npm-release profile. Consolidate antrun tasks and use Maven property replacement rather than brute force replace in npm-publish script. Eliminate duplicated string in POM by using atomist.node.module property.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TypeScript sources up several levels to eliminate
node_modules/@atomistin the source path. GitHub will now properlyshow diffs to the TypeScript source.
Fixes #442
Move TypeScript copy and and generation tasks to the main build, not
just on the npm-release profile. Consolidate antrun tasks and use
Maven property replacement rather than brute force replace in
npm-publish script. Eliminate duplicated string in POM by using
atomist.node.module property.