-
Notifications
You must be signed in to change notification settings - Fork 13
Configure GitHub diffs for TypeScript #442
Comments
The git CLI shows the TypeScript diff without any gitattributes changes. We'll see what we can do. |
yeah, super low priority from my perspective. I just wanted to note it |
This is probably the cause: https://github.com/github/linguist/blob/master/lib/linguist/generated.rb#L318 It treats files whose paths contain |
Reading the docs, it appears the vendor detection excludes the files from stats and the generated detection suppresses the diffs. Unfortunately, while there is a way to override vendor detection, there does not appear to be a way to suppress the generated detection. We may just need to move them out from under a node_modules directory in the source and just adjust the path when they are copied under |
Move TypeScript sources up several levels to eliminate `node_modules/@atomist` in the source path. GitHub will now properly show diffs to the TypeScript source. Fixes #442
Move TypeScript sources up several levels to eliminate `node_modules/@atomist` in the source path. GitHub will now properly show diffs to the TypeScript source. Fixes #442 Move TypeScript copy and and generation tasks to the main build, not just on the npm-release profile. Consolidate antrun tasks and use Maven property replacement rather than brute force replace in npm-publish script. Eliminate duplicated string in POM by using atomist.node.module property.
Move TypeScript sources up several levels to eliminate `node_modules/@atomist` in the source path. GitHub will now properly show diffs to the TypeScript source. Fixes #442 Move TypeScript copy and and generation tasks to the main build, not just on the npm-release profile. Consolidate antrun tasks and use Maven property replacement rather than brute force replace in npm-publish script. Eliminate duplicated string in POM by using atomist.node.module property.
GitHub doesn't seem to render diffs of TypeScript by default. See for example: 7a0c941
It seems like this can be fixed using something in
.gitattributes
The text was updated successfully, but these errors were encountered: