Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

Configure GitHub diffs for TypeScript #442

Closed
justinedelson opened this issue Mar 17, 2017 · 5 comments
Closed

Configure GitHub diffs for TypeScript #442

justinedelson opened this issue Mar 17, 2017 · 5 comments

Comments

@justinedelson
Copy link
Contributor

GitHub doesn't seem to render diffs of TypeScript by default. See for example: 7a0c941

It seems like this can be fixed using something in .gitattributes

@ddgenome
Copy link
Contributor

The git CLI shows the TypeScript diff without any gitattributes changes. We'll see what we can do.

@justinedelson
Copy link
Contributor Author

yeah, super low priority from my perspective. I just wanted to note it

@ddgenome
Copy link
Contributor

This is probably the cause: https://github.com/github/linguist/blob/master/lib/linguist/generated.rb#L318

It treats files whose paths contain node_modules/ as generated.

@ddgenome
Copy link
Contributor

@ddgenome
Copy link
Contributor

Reading the docs, it appears the vendor detection excludes the files from stats and the generated detection suppresses the diffs. Unfortunately, while there is a way to override vendor detection, there does not appear to be a way to suppress the generated detection.

We may just need to move them out from under a node_modules directory in the source and just adjust the path when they are copied under target/ as part of the build.

@ddgenome ddgenome self-assigned this May 8, 2017
ddgenome pushed a commit that referenced this issue May 8, 2017
Move TypeScript sources up several levels to eliminate
`node_modules/@atomist` in the source path.  GitHub will now properly
show diffs to the TypeScript source.

Fixes #442
ddgenome pushed a commit that referenced this issue May 8, 2017
Move TypeScript sources up several levels to eliminate
`node_modules/@atomist` in the source path.  GitHub will now properly
show diffs to the TypeScript source.

Fixes #442

Move TypeScript copy and and generation tasks to the main build, not
just on the npm-release profile.  Consolidate antrun tasks and use
Maven property replacement rather than brute force replace in
npm-publish script.  Eliminate duplicated string in POM by using
atomist.node.module property.
@kipz kipz closed this as completed in #579 May 8, 2017
kipz pushed a commit that referenced this issue May 8, 2017
Move TypeScript sources up several levels to eliminate
`node_modules/@atomist` in the source path.  GitHub will now properly
show diffs to the TypeScript source.

Fixes #442

Move TypeScript copy and and generation tasks to the main build, not
just on the npm-release profile.  Consolidate antrun tasks and use
Maven property replacement rather than brute force replace in
npm-publish script.  Eliminate duplicated string in POM by using
atomist.node.module property.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants