Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for MultiPropertyModel #299

Merged
merged 9 commits into from
Jun 11, 2021
Merged

Proposal for MultiPropertyModel #299

merged 9 commits into from
Jun 11, 2021

Conversation

stefaanhessmann
Copy link
Collaborator

I tested this on QM9 for single and multiple properties and it seems to run well.
Arguments can be passed as list (for multi) and as the single-prop arguments, so the SinglePropertyModel could be replaced by this.

@stefaanhessmann
Copy link
Collaborator Author

stefaanhessmann commented Jun 11, 2021

change of log titles prevents errors with property names that contain "_" because the split("_") of {pname}_{metric_name} will fail if pname also contains a "_". Therefore I changed it to {pname}:{metric_name}

@ktschuett ktschuett merged commit e467888 into dev Jun 11, 2021
@ktschuett ktschuett deleted the sh/multiproperty branch June 11, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants