Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LightningLoggerBase was removed in lightning 1.9 #491

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix: LightningLoggerBase was removed in lightning 1.9 #491

merged 2 commits into from
Feb 9, 2023

Conversation

stefaanhessmann
Copy link
Collaborator

No description provided.

@stefaanhessmann
Copy link
Collaborator Author

bug fix: pytorch_lightning.loggers.LightningLoggerBase was replaced by pytorch_lightning.loggers.logger.Logger in lightning 1.9

mgastegger
mgastegger requested changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@mgastegger mgastegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update requirements.txt and setup.py to use only ligthning versions >= 1.9.0?

@stefaanhessmann
Copy link
Collaborator Author

done

@mgastegger mgastegger merged commit 49b2bb5 into master Feb 9, 2023
@mgastegger mgastegger deleted the sh/lightning_update branch February 9, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgastegger mgastegger mgastegger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefaanhessmann @mgastegger