-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a stratified sampler #539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/schnetpack into jl-sh/stratified_sampler
…g/schnetpack into jl-sh/stratified_sampler
…g/schnetpack into jl-sh/stratified_sampler
jnsLs
requested review from
Maltimore
and removed request for
stefaanhessmann
February 15, 2024 14:16
Maltimore
reviewed
Feb 16, 2024
Co-authored-by: Malte Esders <git@maltimore.info>
Co-authored-by: Malte Esders <git@maltimore.info>
Maltimore
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the StratifiedSampler class takes a partition_criterion (class), which defines the property for the sampling process.
Currently there are two classes implemented suitable for parition_criterion, namely NumberOfAtomsCriterion and PropertyCriterion. The former can, e.g., be used to train QM9 while making sure that small molecules are sampled as often as larger molecules. The latter emphasizes on property ranges which are underrepresented in the dataset.
the property stratified sampler can be utilized by adding +data/sampler=stratified_property in the CLI