Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the functionality to define matmul precision for pytorch in configs #611

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Adding the functionality to define matmul precision for pytorch in configs #611

merged 2 commits into from
Mar 12, 2024

Conversation

khaledkah
Copy link
Collaborator

No description provided.

@khaledkah khaledkah requested a review from jnsLs February 28, 2024 14:48
jnsLs
jnsLs requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@jnsLs jnsLs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Khaled! It looks good. Could you maybe add one or two sentences in the documentation? Otherwise people will have a hard time finding this feature.

docs/userguide/configs.rst might be a good place for that

@khaledkah
Copy link
Collaborator Author

Done

@jnsLs jnsLs merged commit 3be0235 into master Mar 12, 2024
@khaledkah khaledkah deleted the torch_matmul branch March 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsLs jnsLs jnsLs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaledkah @jnsLs