Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kk/qm7 x #616

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Kk/qm7 x #616

merged 2 commits into from
Apr 19, 2024

Conversation

khaledkah
Copy link
Collaborator

No description provided.

stefaanhessmann
stefaanhessmann reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@stefaanhessmann stefaanhessmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @twoPaiSquared !
Could you also add a config YAML file with meaningful example settings to the config folder?

@stefaanhessmann stefaanhessmann mentioned this pull request Mar 18, 2024
Closed
stefaanhessmann
stefaanhessmann approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@stefaanhessmann stefaanhessmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@stefaanhessmann
Copy link
Collaborator

thanks for the contribution! I will merge it now and we can add the config file later

@stefaanhessmann stefaanhessmann merged commit 337fa3f into master Apr 19, 2024
@stefaanhessmann stefaanhessmann deleted the kk/qm7-x branch April 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefaanhessmann stefaanhessmann stefaanhessmann approved these changes

@jnsLs jnsLs Awaiting requested review from jnsLs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaledkah @stefaanhessmann