feat(x/gov): validators can only vote with own stake #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
added a commit
that referenced
this pull request
Feb 22, 2024
While reviewing #20, I found that the tally result assertion was weak, since it only ensures that the expected tally result is not empty. This change improves that for tests that imply vote inheritance, the first commit e257af4 re-enables vote inheritance and improves the tally result assertion. The second commit 3696c7c disables vote inheritance again and updates the assertions to show that vote inheritance is correctly disabled (removing the `delTokens` additions in the expected tally results).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #7 so that validators are allowed to vote, but cannot use delegations in governance to increase their voting power, they can only vote with their own stake. This seems more sensible wrt the previous solution of removing their ability to vote entirely.
This also addresses #19 as I added comments in the README, and also che changelog should be good. Therefore with this PR we should be able to also merge the feat branch back into main and close #6