Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type batch_size #112

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix type batch_size #112

merged 1 commit into from
Apr 9, 2024

Conversation

QB3
Copy link
Contributor

@QB3 QB3 commented Apr 8, 2024

What does this PR do?

Fix the flag type of the batch_size variable.

I have an additional question for the compute_fid.py script:

  • gen_1_img generates a batch of images
  • compute_fid take itself the batch_size as an argument

Is it batching twice?

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@kilianFatras kilianFatras merged commit ec4da08 into atong01:main Apr 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants