Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose eps as a parameter in sample_location_and_conditional_flow #122

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

moinnadeem
Copy link
Contributor

What does this PR do?

Our use case requires controlling determinism. The torchcfm has two sampling-based calls that forward RNG state: t and eps. t is exposed to the user via an argument, but eps is not. This PR exposes eps to the user in case they want to set that.

This shouldn't break any existing behavior.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Yes!

@kilianFatras
Copy link
Collaborator

Hello.

Thank you for your contribution. I think that this parameter should be added to all sample_location_and_conditional_flow. In order to ensure good behaviour, I also would like some tests to be updated. I let @atong01 choosing if we really need this in the current library as it seems to be a very specific use case.

@atong01 atong01 self-assigned this Jul 10, 2024
@atong01 atong01 merged commit c710150 into atong01:main Jul 10, 2024
1 of 31 checks passed
@atong01 atong01 mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants