Add option to create minio clusters #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what's up with the test: |
|
If you do molecule converge and you connect to the containers is minio running? It might be that for whatever reason minio fails to start. I'll give it a try later and try to see what's up. |
|
Figured it out, Minio is very sensitive to the setup of volumes in the erasure code mode. |
paulfantom
reviewed
Jun 25, 2018
README.md
Outdated
| ```yaml | ||
| minio_server_datadirs: | ||
| - '/minio-data' | ||
| minio_server_cluster_nodes: |
There was a problem hiding this comment.
It needs at least 4 nodes, let's not confuse users with 3 nodes in example.
paulfantom
reviewed
Jun 25, 2018
|
|
||
| ```yaml | ||
| minio_server_datadirs: | ||
| - '/minio-data' |
There was a problem hiding this comment.
This needs at least 4 directories, not 1.
There was a problem hiding this comment.
You need 4 storage targets over the whole cluster, not per server.
|
Overall it looks good, I just dropped some comments regarding documentation. |
|
@paulfantom I added some additional notes to the README. |
Add a cluster list that overrides the datadirs list, this allows for local creation of data storage directories separate from a list of cluster members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cluster list that overrides the datadirs list, this allows for
local creation of data storage directories separate from a list of
cluster members.