Fix atoum command exit codes #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,7 +121,27 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $reportCli->addWriter($writerCli); | |||
| } | |||
|
|
|||
| $runner->run($this->getAtoumArguments()); | |||
| try { | |||
| $score = $runner->run()->getRunner()->getScore(); | |||
There was a problem hiding this comment.
I think you forgot to add the parameter $this->getAtoumArguments()to the run method because without it it's not working.
Without this parameters I have the message ``Error: Unable to add test file 'atoum'`.
But except that it's working nicely, good job man.
There was a problem hiding this comment.
Let me fix it! Thanks for you feedback.
I'll update the PR, merge it and issue a new release ;)
|
Thanks man. |
|
@maxailloud in less than one hour ;) |
|
Sweet, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97
@maxailloud this should fix your issue. Would you have some time to test this branch and confirm it's OK ?
Thanks.