Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add television binary #62

Closed
wants to merge 2 commits into from
Closed

Conversation

atrovato
Copy link
Owner

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@atrovato atrovato linked an issue Oct 30, 2022 that may be closed by this pull request
@atrovato atrovato force-pushed the google-actions-television-power branch from 4722532 to 379b87b Compare October 31, 2022 15:37
@atrovato atrovato force-pushed the google-actions-television-power branch from 379b87b to 0cc0bdf Compare November 21, 2022 18:37
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #62 (3584ca7) into master (827bce8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   97.56%   97.57%           
=======================================
  Files         653      657    +4     
  Lines        9952     9973   +21     
=======================================
+ Hits         9710     9731   +21     
  Misses        242      242           
Impacted Files Coverage Δ
...e-actions/lib/traits/googleActions.on_off.trait.js 100.00% <ø> (ø)
...ions/lib/deviceTypes/googleActions.curtain.type.js 100.00% <100.00%> (ø)
...ions/lib/deviceTypes/googleActions.shutter.type.js 100.00% <100.00%> (ø)
...e-actions/lib/deviceTypes/googleActions.tv.type.js 100.00% <100.00%> (ø)
...r/services/google-actions/lib/deviceTypes/index.js 100.00% <100.00%> (ø)
...ctions/lib/traits/googleActions.openClose.trait.js 100.00% <100.00%> (ø)
server/services/google-actions/lib/traits/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atrovato atrovato force-pushed the google-actions-television-power branch from 0cc0bdf to d13d70d Compare March 18, 2023 20:05
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3584ca7
Status: ✅  Deploy successful!
Preview URL: https://6f8985e3.gladys.pages.dev
Branch Preview URL: https://google-actions-television-po.gladys.pages.dev

View logs

@atrovato atrovato force-pushed the google-actions-television-power branch from d13d70d to 69d42e6 Compare April 8, 2023 09:14
@atrovato atrovato force-pushed the google-actions-television-power branch from 69d42e6 to 3584ca7 Compare April 8, 2023 09:18
@atrovato atrovato marked this pull request as draft May 4, 2023 07:52
@atrovato atrovato closed this May 20, 2023
@atrovato atrovato deleted the google-actions-television-power branch May 20, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Television Power on Google Home
1 participant