Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide password anymore #80

Closed
wants to merge 1 commit into from
Closed

Conversation

atrovato
Copy link
Owner

@atrovato atrovato commented Apr 6, 2023

Fixes GladysAssistant#1724

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@atrovato atrovato force-pushed the atrovato/issue1724 branch from 244c4d3 to 02adedd Compare April 6, 2023 17:59
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa488c8
Status: ✅  Deploy successful!
Preview URL: https://27e0e205.gladys.pages.dev
Branch Preview URL: https://atrovato-issue1724.gladys.pages.dev

View logs

@atrovato atrovato force-pushed the atrovato/issue1724 branch 2 times, most recently from 93257e2 to be0d7ce Compare April 6, 2023 18:19
@atrovato atrovato force-pushed the atrovato/issue1724 branch from be0d7ce to fa488c8 Compare April 6, 2023 18:24
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #80 (fa488c8) into master (145e9b7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   97.56%   97.56%   -0.01%     
==========================================
  Files         653      653              
  Lines        9948     9946       -2     
==========================================
- Hits         9706     9704       -2     
  Misses        242      242              
Impacted Files Coverage Δ
server/services/mqtt/api/mqtt.controller.js 100.00% <ø> (ø)
server/services/mqtt/lib/constants.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atrovato atrovato closed this Apr 7, 2023
@atrovato atrovato deleted the atrovato/issue1724 branch April 7, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT: Sometimes the UI displays "******" when vizualizing the password
1 participant