Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to handle PACs support for critical-section #72

Closed
michalfita opened this issue Dec 22, 2023 · 0 comments
Closed

We need to handle PACs support for critical-section #72

michalfita opened this issue Dec 22, 2023 · 0 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Milestone
HAL Release 0.5.0

Comments

@michalfita
Copy link
Collaborator

Digging in changes to svd2rust and how other PACs did things I figured we need critical-section feature in HAL that would enable critical-section dependency in PACs. I'm adding this to PACs at the moment, the next step is to fix things here.

To do this nicely we need breaking change is how rt feature is handled, to simplify things and avoid viscous cycle of bizarre feature names.
@michalfita michalfita added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 22, 2023
@michalfita michalfita mentioned this issue Dec 22, 2023
Merged
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Foundation: rearrange nested features
533b0eb 
Since Rust 1.60 it's possible to enable dependencies' features only for included dependencies.

That's going to work for `rt` and `critical-section` and some other features in future.
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Fix formatting of build.rs
dbfa277
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Things don't play in our favour
f6739f5
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Fix examples to work with new alpha release
56ee0f9
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] All examples back to take()
6552571 
```
let pac = hal::pac::Peripherals::take().unwrap();
```
instead of
```
let pac = hal::pac::Peripherals::take().unwrap();
```
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Make critical-section optional for HAL crate
a631cc0
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Fix second example missed first time
af31fbe
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Scope creep: fix bumped-up USB support (HAL & example)
fb4c01e
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Remove rogue whitespace
ad7af38
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] Fix formatting of amended fragment in example
c809595
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] That's USB change hit me badly
96b8f9d 
It would be nice to have a tool that extracts all basic check from workflow to be run before commit.

Not working on machine I normally burn for this stuff has downsides, as I rush things...
michalfita added a commit that referenced this issue Dec 23, 2023
@michalfita
[Fixes #72] USB require fix in doctests
8775dd0
michalfita added a commit that referenced this issue Jan 3, 2024
@michalfita
[Fixes #72] Cleaning-up
a2cfe05
michalfita added a commit that referenced this issue Jan 3, 2024
@michalfita
[Fixes #72] Update CHANGELOG.md
0a4010d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
HAL Release 0.5.0
Development

No branches or pull requests
1 participant
@michalfita