pass VERSION via CI

atuchin-m · Oct 24, 2023 · 3498dba · 3498dba
1 parent dd4379c
commit 3498dba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/deploy-to-appengine.yml b/.github/workflows/deploy-to-appengine.yml
@@ -27,3 +27,5 @@ jobs:
         with:
           python-version: '3.7'
       - run: python dashboard/bin/deploy --promote app.yaml api.yaml upload.yaml upload-processing.yaml dispatch.yaml index.yaml
+        env:
+          VERSION: ${{github.run_number}}
diff --git a/dashboard/dev_dockerfiles/Dockerfile b/dashboard/dev_dockerfiles/Dockerfile
@@ -4,8 +4,6 @@ ARG PROTOBUF_VERSION=3.6.1.3-2
 
 ENV PATH=/usr/local/depot_tools:${PATH}
 
-# TODO(atuchin): do we need to set up the version manually?
-# ENV VERSION=1005
 
 # The latest version is in sid repo. So need to specify the
 # version of dependency to avoid version conflix if you want