Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors when offline #516

Closed
dabeeeenster opened this issue Aug 31, 2022 · 5 comments
Closed

Log errors when offline #516

dabeeeenster opened this issue Aug 31, 2022 · 5 comments

Comments

@dabeeeenster
Copy link

I'm getting errors when the sync server is not reachable that are polluting my terminal - is this just me? error sending request for url and some additional items?

Thanks for the project - use it multiple times a day!

@ellie
Copy link
Member

ellie commented Aug 31, 2022

Happy to hear you like Atuin!

Hmm those errors shouldn't be making their way to your terminal.

Just a couple of questions

What shell do you use?

How have you setup the atuin integration?

@dabeeeenster
Copy link
Author

Hi,

Using fish shell on MacOS. Getting this sort of thing:

image

Integrating like this in fish.config:

    # Try https://github.com/ellie/atuin
    # dont bind to up arrow
    set ATUIN_NOBIND true
    atuin init fish | source
    # But bind to CTRL+R
    bind \cr _atuin_search

@conradludgate
Copy link
Collaborator

Hmm, I'm not to familiar with fish, but it does look like we are missing the /dev/null redirect that we use for bash/zsh. Maybe that's the issue

@conradludgate
Copy link
Collaborator

I can confirm. We are currently using &; disown to spawn the end command in the background, but my testing shows it still outputs the stdout/err. We just need to add &>/dev/null and it should be good

conradludgate added a commit that referenced this issue Sep 1, 2022
ellie pushed a commit that referenced this issue Sep 1, 2022
@ellie
Copy link
Member

ellie commented Oct 8, 2022

Resolved by #518

@ellie ellie closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants