Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug statement when changing account password #2355

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

TymanWasTaken
Copy link
Contributor

This was introduced in my PR #1615 without being noticed somehow, I just happened to look at the diff of that PR and saw the macro I must have accidentally left in it. I just checked and it does indeed print the request when you attempt to change your password in the CLI, whoops!

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Not really a big deal leaving this in though tbh

  1. It's the response, not the request
  2. Printing the details when debug logging is on is fairly reasonable

I don't feel strongly either way though so happy to merge this

@ellie ellie merged commit 72a562a into atuinsh:main Aug 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants