Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better cursor search #473

Merged
merged 7 commits into from
Sep 11, 2022
Merged

better cursor search #473

merged 7 commits into from
Sep 11, 2022

Conversation

conradludgate
Copy link
Collaborator

@conradludgate conradludgate commented Jul 3, 2022

I noticed we were using char indices for cursor support, but we can use utf8 byte indices for better performance. Refactored into a Cursor type with proper tests so we don't accidentally break it in future

@conradludgate conradludgate enabled auto-merge (squash) July 3, 2022 13:06
@conradludgate conradludgate requested a review from ellie September 10, 2022 09:18
@conradludgate
Copy link
Collaborator Author

Sorry, those last 2 commits are pretty chunky. I'd suggest reviewing by commit.

The last 2 commits are

  • move methods to state - where I changed methods from taking app: &mut State and instead made them &mut self methods within impl State.
  • refactor search modules - where I moved the interactive search and the Events/Cursor type as well into the search directory.

@conradludgate
Copy link
Collaborator Author

I can split the PR if you want :P

@conradludgate conradludgate merged commit 702a644 into main Sep 11, 2022
@conradludgate conradludgate deleted the update-search branch September 11, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants