Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for prepending a path to all routes for the server #484

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Add support for prepending a path to all routes for the server #484

merged 4 commits into from
Jul 26, 2022

Conversation

morguldir
Copy link
Contributor

I didn't want to set up a domain for this, so I attempted to add support for putting it in a different path.

conradludgate
conradludgate reviewed Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea seems ok. I think this is usually a job for nginx or some other ingress but I don't see why we can't support this too

atuin-server/src/router.rs Outdated Show resolved Hide resolved
docs/server.md Outdated Show resolved Hide resolved
morguldir and others added 2 commits July 26, 2022 08:33
@conradludgate conradludgate enabled auto-merge (squash) July 26, 2022 06:36
conradludgate
conradludgate previously approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

auto-merge was automatically disabled July 26, 2022 06:44

Head branch was pushed to by a user without write access

@conradludgate conradludgate merged commit 0c5e250 into atuinsh:main Jul 26, 2022
@morguldir morguldir deleted the prepend-path-option branch July 26, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradludgate conradludgate conradludgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morguldir @conradludgate