Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated kwargs for process_func_args #55

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jun 24, 2022

When introducing process_func_args in version 0.8.0 beginning of the year we stated that it will be removed in version 1.0.0.

As I think we should release the new version as 1.0.0, this removes it.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #55 (0096486) into main (89aa217) will not change coverage.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
audinterface/core/segment.py 100.0% <ø> (ø)
audinterface/core/utils.py 100.0% <ø> (ø)
audinterface/core/feature.py 100.0% <100.0%> (ø)
audinterface/core/process.py 100.0% <100.0%> (ø)
audinterface/core/process_with_context.py 100.0% <100.0%> (ø)

@hagenw
Copy link
Member Author

hagenw commented Jun 24, 2022

Note, that in audinterface.Feature I cannot yet remove **kwargs from __init__() as we need it for support of the deprecated unit keyword argument.

@hagenw hagenw requested a review from frankenjoe June 24, 2022 12:21
@frankenjoe
Copy link
Collaborator

Are you sure we should immediately target 1.0.0? Maybe we should release 0.9.0 in between. Also it would be nice to have #54 before we release 1.0.0.

@hagenw
Copy link
Member Author

hagenw commented Jun 27, 2022

I guess, you are right. We added a lot of new stuff, so maybe releasing 0.9.0 first makes sense. On the other hand, it is very unlikely that we will break the API anyway.

But I will set this pull request to WIP for now.

@hagenw hagenw changed the title Remove deprecated kwargs for process_func_args WIP: Remove deprecated kwargs for process_func_args Jun 27, 2022
@hagenw
Copy link
Member Author

hagenw commented Oct 24, 2022

@frankenjoe should we target 1.0.0 as next release or go with 0.10.0?

@frankenjoe
Copy link
Collaborator

Maybe we should wait with 1.0.0 until we know what new functionality we will need to support storing features in audformat. At least reading the features file should be supported, but maybe also their creation. Btw: we have not created an issue regarding feature support in audformat yet, will do now and link it here.

@frankenjoe
Copy link
Collaborator

audeering/audformat#321

@frankenjoe
Copy link
Collaborator

@hagenw if you agree we target 0.10.0 for now, I will prepare an according release as I think we should release the new handling of multi-channel feature extraction as soon as possible.

@hagenw
Copy link
Member Author

hagenw commented Oct 24, 2022

Yes, please go ahead with 0.10.0

@hagenw hagenw changed the title WIP: Remove deprecated kwargs for process_func_args Remove deprecated kwargs for process_func_args Feb 8, 2023
@hagenw
Copy link
Member Author

hagenw commented Feb 8, 2023

I removed WIP as I think we can target version 1.0.0 with the next release?

@frankenjoe
Copy link
Collaborator

There's one more issue I'd like to tackle before, see #100. I have already some code that I was using to avoid this problem I can build on. So it will hopefully not take too long. I'll try to prepare a PR soonish.

@hagenw
Copy link
Member Author

hagenw commented Feb 9, 2023

Cool, don't worry we don't need to rush with this.

@frankenjoe
Copy link
Collaborator

frankenjoe commented Mar 13, 2023

We have solved #100. So from my side, we could now release 1.0.0.

@hagenw
Copy link
Member Author

hagenw commented Mar 13, 2023

I agree, I have rebased main and you can go ahead here.

@frankenjoe frankenjoe merged commit 2f8d40e into main Mar 13, 2023
@frankenjoe frankenjoe deleted the remove-deprecated-kwargs branch March 13, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants