Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Resolve #39. Added initial draft for homepage content. #98

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Resolve #39. Added initial draft for homepage content. #98

merged 1 commit into from
Apr 11, 2024

Conversation

MadsHeilmann
Copy link
Collaborator

To be improved:

  • I wanted to add arrows or other lines between the popovers to signal their connection a bit better visually.
  • In line 13 in popover.tsx i had to add an ignore tag, as i could not figure out how to solve the ESLint issue.

@MadsHeilmann MadsHeilmann linked an issue Apr 8, 2024 that may be closed by this pull request
Landing page #39
Closed
Danar435
Danar435 previously approved these changes Apr 9, 2024
View reviewed changes
audio-engineer
audio-engineer suggested changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@audio-engineer audio-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good, especially in dark mode! Very nice design. There are just some code changes that need to be done. Also consider replacing the icons with MUI icons.

package.json Outdated Show resolved Hide resolved
components/home-page.tsx Outdated Show resolved Hide resolved
components/popover.tsx Outdated Show resolved Hide resolved
components/popover.tsx Outdated Show resolved Hide resolved
components/popover.tsx Outdated Show resolved Hide resolved
components/popover.tsx Outdated Show resolved Hide resolved
components/popover.tsx Outdated Show resolved Hide resolved
audio-engineer
audio-engineer suggested changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@audio-engineer audio-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added one comment to the last review

components/popover.tsx Show resolved Hide resolved
@MadsHeilmann MadsHeilmann merged commit 4bb479f into main Apr 11, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@audio-engineer audio-engineer audio-engineer approved these changes

@Danar435 Danar435 Danar435 approved these changes

@SebastianMygind SebastianMygind Awaiting requested review from SebastianMygind SebastianMygind is a code owner

@TexWO TexWO Awaiting requested review from TexWO TexWO is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landing page
3 participants
@MadsHeilmann @Danar435 @audio-engineer