Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

"Automatic Updates" column should not be added if wp_autoupdates_add_plugins_autoupdates_column_content() wouldn't output any content for that column #56

Closed
pbiron opened this issue Mar 12, 2020 · 0 comments · Fixed by #57
Closed

"Automatic Updates" column should not be added if wp_autoupdates_add_plugins_autoupdates_column_content() wouldn't output any content for that column #56

pbiron opened this issue Mar 12, 2020 · 0 comments · Fixed by #57
Assignees
@pbiron
Labels
bug Something isn't working

Comments

@pbiron
Copy link
Collaborator

pbiron commented Mar 12, 2020

wp_autoupdates_add_plugins_autoupdates_column_content() has an early exit on

if ( ! current_user_can( 'update_plugins' ) || ! wp_autoupdates_is_plugins_auto_update_enabled() ) {
	return;
}

wp_autoupdates_add_plugins_autoupdates_column() should not add the column if the same tests fail.
@pbiron pbiron added the bug Something isn't working label Mar 12, 2020
@pbiron pbiron self-assigned this Mar 12, 2020
pbiron added a commit that referenced this issue Mar 12, 2020
@pbiron
Ensure "Automatic Updates" column is not added if no content would be…
1f0b9b2 
… output in the column.

Be sure to keep the test here in sync with the early exit test in wp_autoupdates_add_plugins_autoupdates_column_content().

Fixes #56
@pbiron pbiron mentioned this issue Mar 12, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pbiron pbiron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@pbiron