Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE chore: upgrade to i18next v21 #344

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

Sayan751
Copy link
Member

Even though the public API for aurelia-i18n does not change, i18next in v21.x introduces breaking changes that may bring surprises for aurelia users. Hence marking this as a BREAKING CHANGE. Major changes are:

  • Plural suffix changed from _plural to _other.
  • Missing interpolation variables are not replaced with empty string by default and you need to set the following initialization options: interpolation: { skipOnVariables: false }

More details can be found here: https://www.i18next.com/misc/migration-guide#v20.x.x-to-v21.0.0.

Even though the public API for aurelia-i18n does not change, i18next in v21.x introduces breaking changes that may bring surprises for aurelia users. Hence marking this as a BREAKING CHANGE. Major changes are:

- Plural suffix changed from `_plural` to `_other`.
- Missing interpolation variables are not replaced with empty string by default and you need to set the following initialization options: `interpolation: { skipOnVariables: false  }`

More details can be found here: https://www.i18next.com/misc/migration-guide#v20.x.x-to-v21.0.0.
@Sayan751 Sayan751 changed the title chore: upgrade to i18next v21 BREAKING CHANGE chore: upgrade to i18next v21 Jun 14, 2022
@Sayan751 Sayan751 requested review from bigopon and zewa666 June 14, 2022 17:28
@coveralls
Copy link

coveralls commented Jun 14, 2022

Pull Request Test Coverage Report for Build 3519b320-27db-4d28-801c-60ea939e5efa

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.714%

Totals Coverage Status
Change from base Build f5827372-46fe-46f2-bf28-3a5bc283c9c1: 0.0%
Covered Lines: 406
Relevant Lines: 477

💛 - Coveralls

@zewa666 zewa666 merged commit 224e20b into master Jun 14, 2022
@Sayan751 Sayan751 deleted the topic/i18next-update branch June 14, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants