Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): redirect with token parameters #515

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

jagonalez
Copy link
Contributor

allow redirect to contain token parameters for router config

this closes feature request #483

allow redirect to contain token parameters for router config

this closes feature request aurelia#483
@djensen47
Copy link

Any updates on this? Would be really nice to have.

@davismj davismj self-assigned this Nov 12, 2017
@EisenbergEffect
Copy link
Contributor

@davismj Can you review this? It looks like an interesting feature.

@davismj davismj merged commit aafa070 into aurelia:master Mar 15, 2018
@davismj
Copy link
Member

davismj commented Mar 15, 2018

@jagonalez Sorry for the wait. Sincerely appreciate your hard work as always.

@djensen47 Thanks for your patience. Merged!

@Alexander-Taran
Copy link
Contributor

@jagonalez would you mind creating another PR for docs?
Or explain a bit on how it works.. so we could update the docs with a use case?

@3cp
Copy link
Member

3cp commented Jul 2, 2018

@jagonalez @davismj @EisenbergEffect

This new design of redirect disabled the old usage of redirect as in #607
It also causes regression in #605

This looks like a very isolated change, can we revert this commit for now?

Need to revise the design and add test coverage to ensure not breaking #605 and #607.

@davismj
Copy link
Member

davismj commented Jul 2, 2018

@huochunpeng Yep, now that I have more info I'll be able to add the tests. It's gunna be a bit of work and I should have time this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants