Resolve redirect #592
Closed
Resolve redirect #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigs with single route each
|
Thanks for the hard work Fred. I've never heard of a redirect occurring in the load route step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #480
Use
Promise.resolveinstead ofPromise.rejectwhen handling a redirect.BuildNavigationPlanStep.runwill check if the returned value from.then()is aRedirect, and if so, and callnext.cancel.The tests still pass but it kind of feels like I'm missing something. It seems "too easy". Maybe
LoadRouteStep.runalso needs to be changed (loop through the values and if any of them is aRedirect, callnext.cancel).@davismj Do you know if it's possible for a redirect to end up in
LoadRouteStepbut not inBuildNavigationPlanStep?