refactor: Convert to TypeScript #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using the lowest common denominator, which defaulted to the view port defaults implementation. However, that implementation is better described as a partial. Once setting it to a partial type, it is safe to add the proper, stronger typings.
RoutingComponent does not exist.
`Promise<PipelineResult>` is included in `Promise<PipelineResult | boolean>`.
The use of Slots and Steps in the Pipeline/Provider is a bit sloppy and not clear. Both cases, Slots in the PipelineProvider and Steps in the Pipeline, support either slots or steps respectively or constructors for the associated steps. Adding these types allows us to remove typecasting workarounds. There is one place where some duck typing was used and typecasting is required. I've added a comment describing why.
This command reflects the "to run the project in development mode" instructions. The instructions were updated to use the start command instead. Save a few keystrokes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.