Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string interpolation does not respect skipContentProcessing #21

Closed
Alxandr opened this issue Feb 17, 2015 · 1 comment
Closed

string interpolation does not respect skipContentProcessing #21

Alxandr opened this issue Feb 17, 2015 · 1 comment
Labels
bug

Comments

@Alxandr
Copy link

Alxandr commented Feb 17, 2015

I created a custom element (named resource-pooled) that has the skipContentProcessing metadata added. However, in the constructor of the ResourcePooled behavior class, if I inspect the node, I see the following:

node

The original html:

  <resource-pooled>
    <div>I am so testing pooling here...</div>
    <div>Title (bound value): ${post.title}</div>
  </resource-pooled>

I would expect the html to maintain the interpolation-string (so that I can compile it myself), rather than having injected a value.
EisenbergEffect added a commit that referenced this issue Feb 18, 2015
@EisenbergEffect
fix(view-compiler): elements with skipped content should not be trave…
56b585f 
…rsed

This commit fixes issue #21. When a custom element indicates that its
content should not be processed, the view compiled will not traverse
the child nodes at all. Full responsibility is passed to the
implementor of the custom element.
@EisenbergEffect
Copy link
Contributor

I think I've got this fixed now. Going out in next release. Soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alxandr @EisenbergEffect