#1285 #1340: Disable SSH tab for existing replica set connections as …

…well
austingod · Jan 6, 2021 · c260a63 · c260a63
1 parent ea78a36
commit c260a63
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/src/robomongo/gui/dialogs/ConnectionBasicTab.cpp b/src/robomongo/gui/dialogs/ConnectionBasicTab.cpp
@@ -229,7 +229,7 @@ namespace Robomongo
     {
         bool const isReplica = static_cast<bool>(index);
 
-        _connectionDialog->toggleSshSupport(!isReplica);
+        _connectionDialog->toggleSshSupport(isReplica);
 
         // Replica set
         _membersLabel->setVisible(isReplica);

diff --git a/src/robomongo/gui/dialogs/ConnectionDialog.cpp b/src/robomongo/gui/dialogs/ConnectionDialog.cpp
@@ -114,14 +114,13 @@ namespace Robomongo
         _advancedTab->setDefaultDb(defaultDb);
     }
 
-    void ConnectionDialog::toggleSshSupport(bool newVal)
+    void ConnectionDialog::toggleSshSupport(bool isReplicaSet)
     {
         if (!_sshTab) 
             return;
 
-        _sshTab->setEnabled(newVal);            
-        _sshTab->setSshCheckboxToolTip(newVal ? "" :
-            "SSH is currently not supported for Replica Set connections");
+        _sshTab->setDisabled(isReplicaSet);
+        _sshTab->toggleSshCheckboxToolTip(isReplicaSet);
     }
 
     void ConnectionDialog::restoreWindowSettings()

diff --git a/src/robomongo/gui/dialogs/ConnectionDialog.h b/src/robomongo/gui/dialogs/ConnectionDialog.h
@@ -29,7 +29,7 @@ namespace Robomongo
         void setAuthTab(QString const& db, QString const& username, QString const& pwd);
         void enableSslBasic();
         void setDefaultDb(QString const& defaultDb);
-        void toggleSshSupport(bool newVal);
+        void toggleSshSupport(bool isReplicaSet);
 
     public Q_SLOTS:
         /**

diff --git a/src/robomongo/gui/dialogs/SSHTunnelTab.cpp b/src/robomongo/gui/dialogs/SSHTunnelTab.cpp
@@ -162,16 +162,18 @@ namespace Robomongo
 #endif
 
         setDisabled(_settings->isReplicaSet());
+        toggleSshCheckboxToolTip(_settings->isReplicaSet());
     }
 
     bool SshTunnelTab::sshEnabled() const
     {
         return _sshSupport->isChecked();
     }
 
-    void SshTunnelTab::setSshCheckboxToolTip(QString const & text)
+    void SshTunnelTab::toggleSshCheckboxToolTip(bool isReplicaSet)
     {
-        _sshSupport->setToolTip(text);
+        _sshSupport->setToolTip(!isReplicaSet ? "" :
+            "SSH is currently not supported for Replica Set connections");
     }
 
     void SshTunnelTab::setPasswordFieldsEnabled(bool enabled)

diff --git a/src/robomongo/gui/dialogs/SSHTunnelTab.h b/src/robomongo/gui/dialogs/SSHTunnelTab.h
@@ -30,7 +30,7 @@ namespace Robomongo
         */
         bool sshEnabled() const;
 
-        void setSshCheckboxToolTip(QString const& text);
+        void toggleSshCheckboxToolTip(bool isReplicaSet);
 
     private Q_SLOTS:
         void sshSupportStateChange(int checked);