Skip to content

Commit

Permalink
Merge pull request containerd#10516 from etungsten/ensure-state-dir-p…
Browse files Browse the repository at this point in the history
…erms

Ensure /run/containerd gets created with correct perms
  • Loading branch information
estesp authored Jul 31, 2024
2 parents babfebf + 551ac06 commit 7a80448
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions cmd/containerd/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ func CreateTopLevelDirectories(config *srvconfig.Config) error {
if err := sys.MkdirAllWithACL(config.State, 0o711); err != nil {
return err
}
if config.State != defaults.DefaultStateDir {
// XXX: socketRoot in pkg/shim is hard-coded to the default state directory.
// See https://github.com/containerd/containerd/issues/10502#issuecomment-2249268582 for why it's set up that way.
// The default fifo directory in pkg/cio is also configured separately and defaults to the default state directory instead of the configured state directory.
// Make sure the default state directory is created with the correct permissions.
if err := sys.MkdirAllWithACL(defaults.DefaultStateDir, 0o711); err != nil {
return err
}
}

if config.TempDir != "" {
if err := sys.MkdirAllWithACL(config.TempDir, 0o711); err != nil {
Expand Down

0 comments on commit 7a80448

Please sign in to comment.