-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds OS X as a target. I'm doing this to then have the meteor-ios project also target OS X #14
Conversation
…ject also target OS X. Todo: (could use some help!) * For some reason the tests to remove the items fail - I looked into it and the keychain API is failing to remove them because it cant find them. Something is up with the query. Signed-off-by: Mathieu Tozer <mathieutozer@gmail.com>
@mathieutozer thanks for the PR. Can you change the It's odd about the failing test, these are in OS X or iOS? |
I was running them on OS X, will look into the failure and update. Although
|
Might be the query as you mentioned because I think an extra parameter is needed in OSX to fetch/delete items, I am far from an OS X expert 😄, but I'll have to research a little bit more. |
Not sure why travis failed again - I was able to run those commands locally. Could you take a look please? Also, should the pods be added to the commit? It doesn't look like it... |
@mathieutozer I'll take a look later today. |
@mathieutozer sorry but I am busy with other stuff so I couldn't check why the OS X test to remove entries fails. The latest commit fails in travis because you need to mark the scheme If you can remove entries in your sample OS X app I'll merge this, once you fix the scheme issue, and deal with that failing test. |
Also its trying to find the Podfile here |
No worries I've been pretty busy too. Will fix those things so it's green and then move on. |
I'm pretty sure I have pushed the A0SimpleKeychainOSX scheme... let's see how this run goes |
Finally! |
Ping! Can we pull this? |
Adds OS X as a target. I'm doing this to then have the meteor-ios project also target OS X
I'll try to release this as soon as I can. I wanted to check the OS X tests issues and to merge everything to a single workspace (to keep my sanity 😄 ), but I am stuck with a lot of other stuff. |
No problems - let me know when it's ready to go! |
Todo: (could use some help!)
Signed-off-by: Mathieu Tozer mathieutozer@gmail.com