Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OS X as a target. I'm doing this to then have the meteor-ios project also target OS X #14

Merged
merged 5 commits into from
May 27, 2015

Conversation

mathieutozer
Copy link
Contributor

Todo: (could use some help!)

  • For some reason the tests to remove the items fail - I looked into it and the keychain API is failing to remove them because it cant find them. Something is up with the query.

Signed-off-by: Mathieu Tozer mathieutozer@gmail.com

…ject also target OS X.

Todo: (could use some help!)
* For some reason the tests to remove the items fail - I looked into it and the keychain API is failing to remove them because it cant find them. Something is up with the query.

Signed-off-by: Mathieu Tozer <mathieutozer@gmail.com>
@hzalaz
Copy link
Member

hzalaz commented May 4, 2015

@mathieutozer thanks for the PR. Can you change the .travis.yml to run at least iOS tests which is why it's failing now?.

It's odd about the failing test, these are in OS X or iOS?

@mathieutozer
Copy link
Contributor Author

I was running them on OS X, will look into the failure and update. Although
I still don't know why the removal function fails for OS X and not for iOS.
Any idea?
2015年5月4日(月) 6:49 Hernan Zalazar notifications@github.com:

@mathieutozer https://github.com/mathieutozer thanks for the PR. Can
you change the .travis.yml to run at least iOS tests which is why it's
failing now?.

It's odd about the failing test, these are in OS X or iOS?


Reply to this email directly or view it on GitHub
#14 (comment).

@hzalaz
Copy link
Member

hzalaz commented May 5, 2015

Might be the query as you mentioned because I think an extra parameter is needed in OSX to fetch/delete items, I am far from an OS X expert 😄, but I'll have to research a little bit more.
l can try running the tests from your fork, until you fix the travis.yml.

@mathieutozer
Copy link
Contributor Author

Not sure why travis failed again - I was able to run those commands locally. Could you take a look please?

Also, should the pods be added to the commit? It doesn't look like it...

@hzalaz
Copy link
Member

hzalaz commented May 11, 2015

@mathieutozer I'll take a look later today.

@hzalaz
Copy link
Member

hzalaz commented May 13, 2015

@mathieutozer sorry but I am busy with other stuff so I couldn't check why the OS X test to remove entries fails. The latest commit fails in travis because you need to mark the scheme A0SimpleKeychainOSX as shared in Xcode, otherwise it will only stay in your mac 😄 .

If you can remove entries in your sample OS X app I'll merge this, once you fix the scheme issue, and deal with that failing test.

@hzalaz
Copy link
Member

hzalaz commented May 13, 2015

Also its trying to find the Podfile here Example/Podfile. To make this quick, just make iOS test run and we'll see OS X tests later

@mathieutozer
Copy link
Contributor Author

No worries I've been pretty busy too. Will fix those things so it's green and then move on.

@mathieutozer
Copy link
Contributor Author

I'm pretty sure I have pushed the A0SimpleKeychainOSX scheme... let's see how this run goes

@mathieutozer
Copy link
Contributor Author

Finally!

@mathieutozer
Copy link
Contributor Author

Ping! Can we pull this?

hzalaz added a commit that referenced this pull request May 27, 2015
Adds OS X as a target. I'm doing this to then have the meteor-ios project also target OS X
@hzalaz hzalaz merged commit 62f07e5 into auth0:master May 27, 2015
@hzalaz
Copy link
Member

hzalaz commented May 27, 2015

I'll try to release this as soon as I can. I wanted to check the OS X tests issues and to merge everything to a single workspace (to keep my sanity 😄 ), but I am stuck with a lot of other stuff.

@mathieutozer
Copy link
Contributor Author

No problems - let me know when it's ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants