Fixed A0LocalAuthenticationCapable macro #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
requested review from
adamjmcgrath
and removed request for
a team
adamjmcgrath
approved these changes
Feb 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The macro was not checking the minimum supported versions for iOS and macOS. Plus it failed if there was a target for one of these OS present in the project, but the current target was a different OS, e.g. tvOS.
References
Testing
This change has been tested manually on both platforms (iOS and macOS), by importing the library on sample apps and checking the visibility of elements gated by the
A0LocalAuthenticationCapablemacro.[ ] This change adds unit test coverage (or why not)
[X] This change has been tested on the latest version of the platform/language or why not
Checklist
[X] I have read the Auth0 general contribution guidelines
[X] I have read the Auth0 Code of Conduct
[X] All existing and new tests complete without errors