Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchId: Determine reason for failed dataForKey: call #9

Merged
merged 2 commits into from
Jan 15, 2015

Conversation

Yspadadden
Copy link
Contributor

Added overload for dataForKey: that returns an error code to the caller.

The main reason is to determine the cause for a nil return value in a TouchId situation.
Did the method return nil because the key really was not found, or did the user simply
fail to authenticate or cancel the authentication request.

The main reason is to determine the cause for a nil return value in a TouchId situation.
Did the method return nil because the key really was not found, or did the user simply
fail to authenticate or cancel the authentication request.
@hzalaz
Copy link
Member

hzalaz commented Jan 15, 2015

@Yspadadden thanks for the PR!.
Just two quick changes and I'll merge it:

  • For the error domain just use "com.auth0.simplekeychain"
  • Wrap all error messages in NSLocalizedString or maybe better NSLocalizedStringFromTable using SimpleKeychain as the table name.

Thanks again.

@Yspadadden
Copy link
Contributor Author

@hzalaz OK, made the changes. Hope this is OK now. Otherwise just comment again.

Thanks

Regards

Yspadadden

hzalaz added a commit that referenced this pull request Jan 15, 2015
TouchId: Determine reason for failed dataForKey: call
@hzalaz hzalaz merged commit d449f46 into auth0:master Jan 15, 2015
@hzalaz
Copy link
Member

hzalaz commented Jan 15, 2015

👍 merged. I'll release it in CocoaPods soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants