Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Angular 13 and below #777

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Oct 30, 2023

Changes

Ensures we compile using Angular 14, with the consequence that we only support Angular 14 and above.
Given that Angular 13 and below are no longer supported by Google, this is fine.

References

https://angular.io/guide/releases#support-policy-and-schedule

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner October 30, 2023 07:51
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fa81f0) 85.71% compared to head (dc166fc) 47.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #777       +/-   ##
===========================================
- Coverage   85.71%   47.00%   -38.71%     
===========================================
  Files           2        4        +2     
  Lines           7      117      +110     
  Branches        0       38       +38     
===========================================
+ Hits            6       55       +49     
- Misses          1       60       +59     
- Partials        0        2        +2     
Files Coverage Δ
projects/angular-jwt/src/lib/jwthelper.service.ts 79.03% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederikprijck
Copy link
Member Author

The drop in coverage reporting is expected as it was not tracking the correct tests.

@frederikprijck frederikprijck merged commit f51c463 into main Oct 31, 2023
5 of 6 checks passed
@frederikprijck frederikprijck deleted the chore/bump-angular branch October 31, 2023 10:13
@frederikprijck frederikprijck changed the title Upgrade to Angular 14 Drop support for Angular 13 and below Oct 31, 2023
@frederikprijck frederikprijck mentioned this pull request Oct 31, 2023
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants