generateUrl() in BaseAuth0 is creating bad URLs

[scottbergeron]

When I make the following call for creating a User URL

$url = $this->generateUrl('api', '/users');

it returns https://company.auth0.com/apiusers

The problem seems to be the '/' removing part of this function

final protected function generateUrl($domain_key, $path = '/') 
{
    $base_domain = self::$URL_MAP[$domain_key];
    $base_domain = str_replace('{domain}', $this->domain, $base_domain);

    if ($path[0] === '/') {
        $path = substr($path, 1);
    }

    return $base_domain.$path;
}

There's two easy ways to fix this issue:

1. Remove the if ($path[0] ==='/') {...etc lines from the function OR
2. In $URL_MAP add a '/' character to the end of each url. So turn

public static $URL_MAP = array( 'api' => 'https://{domain}/api', 'authorize' => 'https://{domain}/authorize', 'token' => 'https://{domain}/oauth/token', 'user_info' => 'https://{domain}/userinfo', );

into

public static $URL_MAP = array( 'api' => 'https://{domain}/api/', 'authorize' => 'https://{domain}/authorize/', 'token' => 'https://{domain}/oauth/token/', 'user_info' => 'https://{domain}/userinfo/', );

[siacomuzzi]

Thanks Scott! The fix is available @ v0.6.5:

• https://packagist.org/packages/auth0/auth0-php#0.6.5
• https://github.com/auth0/Auth0-PHP/releases/tag/0.6.5

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.